-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check black flagged websites on app launch #12792
Check black flagged websites on app launch #12792
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
9abd300
to
670d998
Compare
e667523
to
8a8d8fd
Compare
670d998
to
1513857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @hichamboushaba.
The code changes look good and black-flagging and un-black-flagging
the site worked great!
…to issue/12789-check-black-flagged-websites-on-launch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12792 +/- ##
============================================
+ Coverage 40.80% 40.86% +0.05%
- Complexity 5753 5765 +12
============================================
Files 1237 1237
Lines 69833 69852 +19
Branches 9699 9706 +7
============================================
+ Hits 28498 28545 +47
+ Misses 38706 38672 -34
- Partials 2629 2635 +6 ☔ View full report in Codecov by Sentry. |
Closes: #12789 Closes: #12790
Depends on #12788
Description
This PR adds logic to fetch the site status from the WCPom endpoint on app launch to determine if the site is suspended or not, and then update the corresponding flags, this will ensure two cases:
Steps to reproduce
Testing information
Important: the Jetpack upsells might not show exactly on first launch if the fetch took a little bit long, but they will appear when changing the screen and going back, I think that this is fine for this use case and that listening to the preference to update the UI would be an overkill, a site being suspended or unsuspended wouldn't be a frequent change anyway, let me know what you think.
The tests that have been performed
^
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: