Fix about screen vertical spacing #5576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
dp
withsp
for line height. Technically, evendp
are supported to be used for lineHeight. However, there is a bug in Compose Theme Adapter which breaks vertical spacing whendp
is used. It's quite tricky sincelineHeight
in Compose accepts onlyTextUnit
which doesn't supportdp
.I'm on the edge if we should update our styles from dp to sp or wait for the fix in the library. However, I'm inclined towards updating our code as I suspect this might cause even other side-effects/bugs and we might waste time on them in the future. The change has very minimal impact on the UI only when the OS font size settings is not set to default.
Props to @AnirudhBhat for noticing the issue. It occurs only in
jalapeno
builds since vanilla and wasabi have shorter app name so the app name fits one line.P.S. This PR also updates the hashcode of the
Automattic About
library. This doesn't have any affect, I just forgot to update the commit hash with the merge commit in the previous PR.Testing instructions
Change font size in OS settings and smoke test the app -> there will be some changes in lineHeight spacing, but they should be minimal. Notice for example the
Top Performers
section on the screenshots below.Images/gif
RELEASE-NOTES.txt
if necessary.