This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add bundleanalyzer config and webpack plugin #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve this and use project settings instead
This reverts commit fb0a7c6. The error was not due to the configuration but due to when the plugin was executing becuase we have another webpack plugin that removes the transitionary javascript/css files.
also remove webpack-stats.json from checked in files
|
Can close this now that we're using the bundlesize github action |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently added bundlewatch in #1365, however I noticed that it's detail urls are really long, and it doesn't seem to be comparing changes against master (which is what we want). While browsing the bundlewatch issues I came across a reference to a new service called bundle-analyzer (https://bundle-analyzer.com/) that seems like it might work better so I'm giving it a try.
Some notes:
BUNDLE_ANALYZER_TOKENdefined in the environment (so we're not deploying any production code built through this plugin). Travis is the only environment in which this plugin is then used by default.Note: This will be nice if it works, but with the webpack plugin it creates one build in the bundle-analyzer ui for each webpack configuration (so for every pull that's 5 builds). I've asked a question in their repo on whether that will result in multiple checks added to a pull or not (if yes, then 👍 , if no then 👎 ).