Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Google Pay button in the block Checkout in the editor (3374) #2464

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Fix the Google Pay button in the block Checkout in the editor (3374) #2464

merged 5 commits into from
Oct 3, 2024

Conversation

danieldudzic
Copy link
Collaborator

Description

This PR fixes the Google Pay button in the block checkout editor, by refactoring script loading to allow for custom namespaces.

Steps to Test

  1. Test the express buttons in the block Checkout in the editor and the page - verify they are being displayed correctly.
  2. Make sure to test with Google Pay and Apple Pay enabled.
  3. Make sure as much as possible the script loading script refactor didn't break anything 🙈

Screenshots

Before After
Edit_Page_“Block_Checkout”_‹paypal—_WordPress Edit_Page_“Block_Checkout”_‹paypal—_WordPress

@danieldudzic
Merge branch 'PCP-2645-when-selecting-google-pay-as-a-payment-option-…
d3e1889 
…in-safari-a-developer-error-is-displayed' of github.com:woocommerce/woocommerce-paypal-payments into PCP-3374-google-pay-button-not-displayed-in-the-word-press-editor
@danieldudzic
Merge branch 'trunk' of github.com:woocommerce/woocommerce-paypal-pay…
38b2210 
…ments into PCP-3374-google-pay-button-not-displayed-in-the-word-press-editor
@danieldudzic
Merge branch 'PCP-2645-when-selecting-google-pay-as-a-payment-option-…
d769acf 
…in-safari-a-developer-error-is-displayed' of github.com:woocommerce/woocommerce-paypal-payments into PCP-3374-google-pay-button-not-displayed-in-the-word-press-editor
@danieldudzic
Refactor script loading to allow for adding custom namespaces
09ff65a
@danieldudzic
Merge branch 'trunk' of github.com:woocommerce/woocommerce-paypal-pay…
f25140b 
…ments into PCP-3374-google-pay-button-not-displayed-in-the-word-press-editor
@InpsydeNiklas InpsydeNiklas added this to the 2.9.3 milestone Oct 3, 2024
@Dinamiko Dinamiko merged commit 8592213 into trunk Oct 3, 2024
8 checks passed
@Dinamiko Dinamiko deleted the PCP-3374-google-pay-button-not-displayed-in-the-word-press-editor branch October 3, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinamiko Dinamiko Dinamiko approved these changes

@stracker-phil stracker-phil Awaiting requested review from stracker-phil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@danieldudzic @Dinamiko @InpsydeNiklas