Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that get_the_ID is valid before using #2573

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Check that get_the_ID is valid before using #2573

merged 1 commit into from
Oct 3, 2024

Conversation

AlexP11223
Copy link
Contributor

There was a report that sometimes get_the_ID returns an invalid/string value, so added an is_numeric check and cast to avoid type errors.

Narek13
Narek13 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@Narek13 Narek13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also couldn't reproduce

@Dinamiko Dinamiko merged commit e8917a9 into trunk Oct 3, 2024
9 checks passed
@Dinamiko Dinamiko deleted the PCP-3617-check-id-type branch October 3, 2024 08:40
@Dinamiko Dinamiko added this to the 2.9.3 milestone Oct 10, 2024
@Dinamiko Dinamiko added the bug Something isn't working label Oct 10, 2024
@Dinamiko Dinamiko mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narek13 Narek13 Narek13 approved these changes

@Dinamiko Dinamiko Awaiting requested review from Dinamiko

@danieldudzic danieldudzic Awaiting requested review from danieldudzic

@stracker-phil stracker-phil Awaiting requested review from stracker-phil

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexP11223 @Narek13 @Dinamiko