Declare tokenization for ACDC only when vaulting enabled (3645) #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinamiko
changed the title
Dinamiko
approved these changes
Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2394 the ACDC gateway was showing the "Save" checkbox even if vaulting is disabled because
tokenizationwas always declared insupports. Fixed it, now it should check the vaulting setting like before. I think the subscription renewals is still working, though not sure if I fully understand how to test that.For the PayPal gateway it remains as it is for now, unclear how to handle it properly here (Vaulting vs Vaulting ACDC vs Subscription mode).