-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PayPal Subscriptions API renewal order not created in WooCommerce (3677) #2612
Merged
Dinamiko
merged 12 commits into
trunk
from
PCP-3677-pay-pal-subscriptions-api-renewal-order-not-created-in-woo-commerce
Oct 22, 2024
Merged
PayPal Subscriptions API renewal order not created in WooCommerce (3677) #2612
Dinamiko
merged 12 commits into
trunk
from
PCP-3677-pay-pal-subscriptions-api-renewal-order-not-created-in-woo-commerce
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…order-not-created-in-woo-commerce
…order-not-created-in-woo-commerce
…order-not-created-in-woo-commerce
…order-not-created-in-woo-commerce
stracker-phil
approved these changes
Sep 24, 2024
…order-not-created-in-woo-commerce
Dinamiko
deleted the
PCP-3677-pay-pal-subscriptions-api-renewal-order-not-created-in-woo-commerce
branch
October 22, 2024 10:42
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces time based logic as a fallback when for some reason subscription
_ppcp_is_subscription_renewal
meta is not saved when receiving the firstPAYMENT.SALE.COMPLETED
webhook (for parent order).Steps to reproduce
(Developer only) Manually trigger a
PAYMENT.SALE.COMPLETED
webhook<?php const PAYPAL_WEBHOOK_REQUEST_VERIFICATION = false;
ppcp_subscription
meta and pass it asbilling_agreement_id
in the following request:By following the above steps a developer could delete subscription
_ppcp_is_subscription_renewal
meta and trigger the webhook to see if the time based logic is executed correctly when no meta exist.