Improve context detection #2631
Open
+78
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the detection of the
update_order_review/update_shipping_methodajax requests to fix the possibility of getting a wrong context during these requests, e.g. when the home page contains the cart.Also removed
continuationfrom the context. It was added in #2398 and used in 2 places. I think it is not a good idea to increase complexity of the context, especially if we decide to refactor it in the future. And it was working a bit incorrectly, such as if you are in continuation mode and leave checkout the context still remainscontinuation, while before #2398 it would bemini-cart(it was a bit weird however that when you go to the checkout in continuation mode the context becomesmini-cartbut replacing one weirdness with another one is not great).