Add Custom Placeholder Handling when rendering the card fields (3736) #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narek13
requested review from
Dinamiko,
AlexP11223,
danieldudzic and
stracker-phil
Dinamiko
approved these changes
Sep 30, 2024
Dinamiko
deleted the
PCP-3736-translations-no-longer-applied-to-card-fields-in-2-9-0
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The issue happens because when extracting the card fields logic to corresponding modules we forgot about Custom Placeholder Handling: In old code, we checked if the fields had a placeholder attribute and set it in the field options. This is missing in the new
renderFieldfunction causing the problem with translations.The PR will fix the problem described above by adding the custom placeholder handling functionality.
Issue Description
The translations are no longer applied to Card fields in 2.9.0+ even if the string is still translatable and translations are available.
Steps to Test