Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/i18n: Add missing i18n directory #200

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix/i18n: Add missing i18n directory #200

merged 2 commits into from
Aug 15, 2024

Conversation

Sidsector9
Copy link
Member

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

In PR #166, the i18n directory wasn't included which was pointed out in #194 (comment)

Steps to test the changes in this Pull Request:

  1. Run nvm use && npm ci && npm run build
  2. Extract the generated zip and verify that the .pot files exists.

@Sidsector9 Sidsector9 self-assigned this Aug 14, 2024
@Sidsector9 Sidsector9 mentioned this pull request Aug 15, 2024
Closed
18 tasks
@dkotter dkotter marked this pull request as ready for review August 15, 2024 18:31
@dkotter dkotter merged commit 1ff7704 into trunk Aug 15, 2024
6 checks passed
@dkotter dkotter deleted the fix/i18n branch August 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
status: e2e tests passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sidsector9 @dkotter