-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/202: make "You're connected to Square" page entire UI to be visible #224
base: trunk
Are you sure you want to change the base?
Conversation
exited_on_step: stepData.step, | ||
} | ||
); | ||
window.location.href = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an eslint issue that needs cleaned up here
QA Update: ❌@Sidsector9 Thanks for the PR I cross-checked with the
Could you please check from your end as well? Screen.Recording.2024-09-27.at.3.00.50.PM.mov |
QA Update: ❌Issue - 1 Unable to scroll down in 1024x768 resolution. 1024.768.mp4Issue - 2 In this, fix branch I notice Some screen settings are flickering while selecting. Screen.Recording.2024-10-03.at.5.47.13.PM.mov |
@qasumitbagthariya as discussed on Slack, the minimum supported screen size is |
All Submissions:
Changes proposed in this Pull Request:
This PR uses combination of max/min - width/height media queries to ensure the "Next" button is always visible on the screen for desktop resolution as low as
1280 x 720
.Closes #202
Steps to test the changes in this Pull Request:
1280 x 720
Changelog entry