-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tips and Tricks Main Chapter Landing page #17
base: master
Are you sure you want to change the base?
Conversation
I like that each author is given credit for their work. I don't have any issues with the current format. If we're making the pages modular, there'll be adjustments that will have to be made to the site |
Hmm I guess we could do that, although I think we can leave it as it is for now. Was also gonna ask this about the chapter 7 sub-chapters as well Honestly, I don't think its too big of a deal if the website is left as is. |
Yup chapter 7 works already, but from my impression, I thought you were going to make small markdown files per tip and link them in the main README. Which in this case, would not register as a chapter. But we can always make it a chapter. The site already handles sub-chapters |
Just added:
|
Oops, sorry, been really busy lately 😬 I'll take a look through this tonight and share my comments here! Thank you for the good work @chuanhao01 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there are some minor changes that can be made! Good work! 😄
Minor changes for TIps and Tricks Main chapter's folder Co-authored-by: Woo Jia Hao <[email protected]>
Hey just got around to looking at the changes from a week ago. |
No worries at all! Let's take this slow and just work on this whenever is best 👍 |
I was thinking of making this chapter more modular, where the main chapter's README contains the links and a short description of the tips. Also included a way to credit the tip's author (May or may not be necessary?)
Also adding a section on how to contribute a tip.
Decided this should be a separate PR from actually adding a tips and tricks sub-chapter.
Let me know what you think of the format so far @woojiahao.