Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[문자열 덧셈 계산기] 민경태 미션 제출합니다. #1914

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    e81bf33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2047172 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6b8224 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    54a553d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e482abc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bbe1a9b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    34ab00f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d7cf65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    05084c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    85820c0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3db0f08 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    685a57a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    987c91c View commit details
    Browse the repository at this point in the history
  8. docs: 검사기의 범위 초과 예외처리 기능 뎃셈기로 이동

    -  문자를 숫자로 변환시키는 클래스는 Adder라서 Validator에 어울리지 않는다고 생각함
    GO-TE committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c932d2c View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    0f01bc4 View commit details
    Browse the repository at this point in the history
  2. feat(Adder): 오버 플로우 발생 시 예외 처리 기능 구현

    변경된 점
    - answer 타입 변경 int -> long
    - answer 타입 변경에 따른 getAnswer 타입 변경 int -> long
    GO-TE committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    eb937f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6a3161 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5efe9f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. fix(StringHandler): getNumbers() 모든 수가 1의 자리로 되는 버그 수정

    기존에 두자리 이상 숫자도 한자리씩 잘라 리턴하는 현상 발견
    GO-TE committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    bebc033 View commit details
    Browse the repository at this point in the history
  2. fix(StringHandler): 커스텀 구분자 선언문 추출, 제거 기능 수정

    * extractSeparactor()
    - start index 값 말고, 좀 더 static 하게 변경 (변경 될 가능성 큼)
    - end 입력 되는 \n이 개행문자가 아님을 알리기 위해 이스케이프 문자 추가 (\n -> \n)
    
    * removeCustom()
    - 개행문자가 아님을 알림 (변경 가능성 큼)
    GO-TE committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f192a39 View commit details
    Browse the repository at this point in the history
  3. docs: 문자열 핸들러 기능 구현 목록 수정

    - 이미 분리한 문자열을 넘기고 있어 삭제
    GO-TE committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    93dc649 View commit details
    Browse the repository at this point in the history
  4. fix(Validator): 커스텀 구분자 유무, 입력값 검증 기능 수정

    * hasCustomSeparator()
    - 개행 문자로 인식하지 않도록 수정 (\n -> \n)
    
    * validateInput()
    - 주석 제거
    - 개행문자로 인식하지 않도록 수정 (\n -> \n)
    GO-TE committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    dde4daa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1026689 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9253888 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1d200a7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a801593 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    050b645 View commit details
    Browse the repository at this point in the history
  10. fix(util): Validator 공백 입력시 에러 수정

    * isEmpty() 구현
    - 기존 공백인지 미리 검증 하지 않아 index 초과 에러 발생
    - 공백임을 검증하는 함수 따로 구현 -> 커스텀 구분자 확인, 숫자로 시작하는지 확인 하는 함수에 추가
    - validateInput에 공백인지를 검사하는 코드 대체
    GO-TE committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f9c80d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    c90a512 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9aad1c3 View commit details
    Browse the repository at this point in the history
  3. refactor(SeparatorManage): 커스텀 구분자 추가 이전 이미 존재하는지 검증

    이전에 exists 메소드가 사용되지 않았음
    add 메소드에 구분자가 이미 존재하는지 검증 과정을 거치도록 바꿈
    + test 코드도 이미 존재하는지 없는지 로직에 따라 바꿈 (boolean에서 예외처리하도록)
    GO-TE committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c3dbbc0 View commit details
    Browse the repository at this point in the history
  4. refactor: 하드 코딩 제거

    예외 메세지는 따로 관리하는게 더 여러울 것 같아서 제외했음
    - 커스텀 구분자 접두사, 접미사 Constants에 따로 선언
    - 기본 구분자 리스트를 불변한 리스트로 따로 선언
    - 올바른 구분자 길이 선언
    - 추후 확장을 위한 소수점 선언
    GO-TE committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bdc59bb View commit details
    Browse the repository at this point in the history
  5. docs: 구현 완료 체크

    GO-TE committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4115bc9 View commit details
    Browse the repository at this point in the history