Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[코드 리뷰용 PR] - 재구현 스터디 #250

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[코드 리뷰용 PR] - 재구현 스터디 #250

wants to merge 25 commits into from

Commits on Nov 28, 2023

  1. docs(README): 핵심 기능과 기능 요구사항을 정리한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b380ee1 View commit details
    Browse the repository at this point in the history

  2. feat(Referee): 사용자가 입력한 답과 정답을 비교해서 볼, 스트라이크 개수를 알려준다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    bc9d9dd View commit details
    Browse the repository at this point in the history

  3. feat(BaseBallNumbers): 사용자가 입력한 세자리 수의 유효성을 검증한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8224533 View commit details
    Browse the repository at this point in the history

  4. feat(BaseBallNumber): 사용자가 입력한 각 숫자의 유효성을 검증한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f096adc View commit details
    Browse the repository at this point in the history

  5. test(BaseBallNumbers): 정상적인 숫자 셋인 경우 테스트를 추가한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    bc5992d View commit details
    Browse the repository at this point in the history

  6. feat(Answer): 랜덤으로 정답을 생성해주는 클래스를 추가한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b3fbddb View commit details
    Browse the repository at this point in the history

  7. feat(InputView.readNumbers): 사용자의 입력을 숫자로 가져온다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a22be16 View commit details
    Browse the repository at this point in the history

  8. feat(NumbersConverter): 사용자의 입력을 숫자 야구 게임의 숫자 셋으로 변환한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b37ca8e View commit details
    Browse the repository at this point in the history

  9. feat(InputView): 게임 종료시의 사용자의 입력을 커맨드로 변환한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a3aa77c View commit details
    Browse the repository at this point in the history

  10. feat(OutputView): 게임의 한 턴의 결과를 보여준다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e6badf7 View commit details
    Browse the repository at this point in the history

  11. feat(OutputView): 게임 시 프롬프트 메시지를 출력하는 메서드를 구현한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8df6aa9 View commit details
    Browse the repository at this point in the history

  12. fix(Referee): compare 메서드의 동작의 버그를 고친다 

    * `contains` 에 잘못 들어가 있던 인자를 수정하여 이로 인한 버그를 픽스한다.
    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b9701ec View commit details
    Browse the repository at this point in the history

  13. feat(GameController): 구현한 동작들을 통합하여 시스템을 완성한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    21434dc View commit details
    Browse the repository at this point in the history

  14. feat(NumbersConverter): 숫자형을 숫자 야구 게임의 숫자 셋으로 변환하는 함수를 최상위 확장 함수로 변경한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e68ee10 View commit details
    Browse the repository at this point in the history

  15. style(GameController): 심판 역할과 정답을 생성해내는 역할을 생성주 주입을 하도록 변경한다.

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    40fdfa5 View commit details
    Browse the repository at this point in the history

  16. test(NumbersConverterTest): 테스트 대상 파일이 최상위 함수로 변경된 것을 반영하여 테스트 코드를 수정한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c484f78 View commit details
    Browse the repository at this point in the history

  17. style(AnswerGenerator): 기존 Answer 클래스의 이름을 AnswerGenerator 로 변경한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3cadfe2 View commit details
    Browse the repository at this point in the history

  18. refactor(InputView): 잘못된 커맨드를 입력하면 예외를 던진다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3ed274c View commit details
    Browse the repository at this point in the history

  19. refactor(InputView): 입력 커맨드에 대한 유효성 검증의 위치를 옮긴다 

    * 이전: `InputView` 에서 유효성 검증 후 `Command` 타입으로 변환한다.
* 이후: 유효성 검증과 타입 변환을 `NumbersConverter` 에서 수행한다.
    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    796f037 View commit details
    Browse the repository at this point in the history

  20. test(NumbersConverter): 입력을 커맨드로 변환하고 유효성 검증하는 테스트를 추가한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f81942e View commit details
    Browse the repository at this point in the history

  21. refactor(RefereeTest): 입력값과 정답을 비교해서 결과를 알려주는 테스트에서 여러 케이스를 한번에 테스트한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7c75a95 View commit details
    Browse the repository at this point in the history

  22. refactor(BaseballNumbersTest): 게임에서 사용되는 숫자 셋을 테스트할 때 여러 케이스를 한번에 테스트한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    905a9ba View commit details
    Browse the repository at this point in the history

  23. docs(README): 최종 시스템 UML 을 추가한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1dedcee View commit details
    Browse the repository at this point in the history

  24. style(Referee): 코드의 가독성을 개선한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cd16128 View commit details
    Browse the repository at this point in the history

  25. refactor(RandomAnswerGenerator): 랜덤 수를 생성하는 로직을 개선한다

    @sh1mj1
    sh1mj1 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    765dc92 View commit details
    Browse the repository at this point in the history