-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[로또] 이재원 미션 제출합니다. #190
Open
leejewon97
wants to merge
50
commits into
woowacourse-precourse:main
Choose a base branch
from
leejewon97:leejewon97
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[로또] 이재원 미션 제출합니다. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
열거형 PRICE 생성
메서드 printBuyPrice 생성
정상적인 구입 금액을 String으로 return할 메서드 inputBuyPrice 구현
예외 상활 시 IllegalArgumentException 발생 시킬 메서드 구현
PrintBuy -> Buy PRICE -> PRICE_INPUT
단위테스트를 위한 접근제어자 변경
매서드 buyLotto 생성
메서드 lottoMaker 생성
LottoTest.kt에서 LottoUITest.kt로 이사
밖에서 getter로서 사용하기 위해 메서드 생성
발행한 모든 로또들을 출력하는 메서드 생성
각 메서드 구현 후 테스트 요망
아직 checkInvalidWinningNumbers 미구현 아직 winningNumbersToInt 미구현
당첨 번호 입력 시 구분자(,)로 나눠진 각 문자열의 예외 처리 완료
예외 상황 시 예외 잘 처리
외부에서 함수를 테스트하기 위해
각 Test 클래스의 테스트들도 적용되면서, UI테스트는 사라짐
에러 열거형이나 입력 구문 생성
보너스 번호 입력 구문 출력
숫자가 아닌 경우가 아닌 정수가 아닌 경우를 걸러야 함 1개가 아닌 경우는 들어오지 않음
메서드 inputBonusNumber 구현 완료
메서드 checkInvalidBonusNumber 구현 완료
메서드 printResult 형태만 구현 println위치 약간 수정
보너스 번호는 당첨 번호와 겹치면 안 되기에 인자로 당첨번호를 넘겨줌
LottoService에서 나머지 함수 구현 요망
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.