Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: template에 예상 소요 시간, 실제 소요 시간을 추가한다 #166

Merged
merged 3 commits into from
Jul 24, 2023
Merged

refactor: template에 예상 소요 시간, 실제 소요 시간을 추가한다 #166

merged 3 commits into from
Jul 24, 2023

Conversation

drunkenhw
Copy link
Collaborator

@drunkenhw drunkenhw commented Jul 22, 2023 •
edited by github-actions bot
Loading

📄 Summary

추가했습니다 ~

🙋🏻 More

close #165

@drunkenhw drunkenhw added 📖 문서 문서를 개선하거나 추가 할 필요가 있습니다 🛠️ 리팩터링 개선사항입니다 BE 백엔드 관련 이슈입니다 FE 프론트엔드 관련 이슈입니다 labels Jul 22, 2023
@drunkenhw drunkenhw self-assigned this Jul 22, 2023
@drunkenhw drunkenhw temporarily deployed to test July 22, 2023 12:12 — with GitHub Actions Inactive
feb-dain
feb-dain reviewed Jul 22, 2023
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated
Comment on lines 4 to 7
## 🙋🏻 More
>

## 🕰️ Actual work time
Copy link
Collaborator

@feb-dain feb-dain Jul 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR template도 ## more이 제일 밑에 있으면 좋을 것 같아요!
그리고 ETA 또는 ETC(예상 소요 시간), ATA 또는 ATC(실제 소요 시간)로 적는 거 어때요?

@drunkenhw drunkenhw temporarily deployed to test July 22, 2023 12:30 — with GitHub Actions Inactive
feb-dain
feb-dain approved these changes Jul 22, 2023
View reviewed changes
Copy link
Collaborator

@feb-dain feb-dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영한 것 모두 확인했습니다~ 👍🏻👍🏻

gabrielyoon7
gabrielyoon7 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@gabrielyoon7 gabrielyoon7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 사항에 동의합니다

be-student
be-student approved these changes Jul 22, 2023
View reviewed changes
Copy link
Collaborator

@be-student be-student left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많았어요! 👍

sosow0212
sosow0212 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@sosow0212 sosow0212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@drunkenhw drunkenhw merged commit 62b10cb into develop Jul 24, 2023
1 check passed
@drunkenhw drunkenhw deleted the refactor/165 branch July 24, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosow0212 sosow0212 sosow0212 approved these changes

@gabrielyoon7 gabrielyoon7 gabrielyoon7 approved these changes

@be-student be-student be-student approved these changes

@feb-dain feb-dain feb-dain approved these changes

@kyw0716 kyw0716 Awaiting requested review from kyw0716

@kiarakim kiarakim Awaiting requested review from kiarakim

Assignees

@drunkenhw drunkenhw

Labels
BE 백엔드 관련 이슈입니다 FE 프론트엔드 관련 이슈입니다 📖 문서 문서를 개선하거나 추가 할 필요가 있습니다 🛠️ 리팩터링 개선사항입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

template에 예상 소요 시간, 실제 소요 시간을 추가한다
5 participants
@drunkenhw @sosow0212 @gabrielyoon7 @be-student @feb-dain