Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 검색창 렌더링 기능을 구현하고 웹 접근성 요소를 추가한다 #231

Merged
merged 14 commits into from
Jul 29, 2023
Merged

feat: 검색창 렌더링 기능을 구현하고 웹 접근성 요소를 추가한다 #231

merged 14 commits into from
Jul 29, 2023

Conversation

feb-dain
Copy link
Collaborator

@feb-dain feb-dain commented Jul 29, 2023 •
edited by github-actions bot
Loading

📄 Summary

검색창 렌더링 기능을 구현하고 웹 접근성 요소를 추가한다

🕰️ Actual Time of Completion

4시간

🙋🏻 More

close #224

@feb-dain
refactor: 폴더 구조 개선
d721c01 
[#224]
@feb-dain
Merge branch 'develop' of https://github.com/woowacourse-teams/2023-c…
349dfa7 
…ar-ffeine into feat/224
@feb-dain
feat: 검색창 컴포넌트 여닫는 기능 구현
990d4ef 
[#224]
@feb-dain
refactor: inline css 분리
9776e30 
[#224]
@feb-dain
feat: 검색창 이벤트 핸들러 임시로 구현(onChange, onSubmit)
9c30ce5 
[#224]
@feb-dain
test: 스토리북 title Components → UI로 변경
1237b4c 
[#224]
@feb-dain
refactor: Navigator 폴더 생성 및 이동
edc95a2 
[#224]
@feb-dain
refactor: Text 스타일 컴포넌트에 새로운 속성 추가
fdcaaa5 
[#224]
@feb-dain
refactor: Navigator에 있는 svg 파일 아이콘으로 대체
c3fd3f2 
[#224]
@feb-dain
design: StationSearchWindow 디자인 수정
8439e92 
[#224]
@feb-dain
refactor: Text 컴포넌트에 tag 바꾸는 속성 추가
b96f1f0 
[#224]
@feb-dain
refactor: 웹 접근성 개선
95ab394 
[#224]
@feb-dain
refactor: 시맨틱 태그로 변경
7ab13c7 
[#224]
@feb-dain
fix: 검색창을 열었을 때 필터를 클릭해도 필터창이 열리지 않는 오류 개선
e9f5536 
[#224]
@feb-dain feb-dain added 🛠️ 리팩터링 개선사항입니다 🌱 기능추가 새로운 기능 요청입니다 FE 프론트엔드 관련 이슈입니다 labels Jul 29, 2023
@feb-dain feb-dain self-assigned this Jul 29, 2023
@github-actions
Copy link

🚀storybook: https://storybook.carffe.in/

kyw0716
kyw0716 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@kyw0716 kyw0716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나이스샷

gabrielyoon7
gabrielyoon7 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@gabrielyoon7 gabrielyoon7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 확인해보겠음

@feb-dain feb-dain merged commit 04a0fb8 into develop Jul 29, 2023
3 checks passed
@feb-dain feb-dain deleted the feat/224 branch July 29, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielyoon7 gabrielyoon7 gabrielyoon7 approved these changes

@kyw0716 kyw0716 kyw0716 approved these changes

Assignees

@feb-dain feb-dain

Labels
FE 프론트엔드 관련 이슈입니다 🌱 기능추가 새로운 기능 요청입니다 🛠️ 리팩터링 개선사항입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

검색창 렌더링 기능을 구현하고 웹 접근성 요소를 추가한다
3 participants
@feb-dain @gabrielyoon7 @kyw0716