Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 클라이언트 필터링 컴포넌트를 개선한다 #569

Merged
merged 5 commits into from
Aug 17, 2023
Merged

refactor: 클라이언트 필터링 컴포넌트를 개선한다 #569

merged 5 commits into from
Aug 17, 2023

Conversation

kyw0716
Copy link
Member

@kyw0716 kyw0716 commented Aug 17, 2023 •
edited by github-actions bot
Loading

📄 Summary

  • 패널의 너비를 ref를 통해 참조하지 않고, 상수화 된 값을 통해 참조하도록 수정한다.
  • 열려있는 패널의 개수에 따라 클라이언트 필터링 컴포넌트가 옆으로 이동하도록 수정한다.
  • 마커에 띄워지는 간단 정보창 로직도 가능하다면 수정해본다.

🕰️ Actual Time of Completion

1시간

🙋🏻 More

close #566

@kyw0716 kyw0716 added 🛠️ 리팩터링 개선사항입니다 FE 프론트엔드 관련 이슈입니다 labels Aug 17, 2023
@kyw0716 kyw0716 self-assigned this Aug 17, 2023
@kyw0716 kyw0716 temporarily deployed to test August 17, 2023 06:00 — with GitHub Actions Inactive
@github-actions
Copy link

🚀storybook: https://storybook.carffe.in/

@gabrielyoon7 gabrielyoon7 merged commit dd675c4 into develop Aug 17, 2023
4 checks passed
@gabrielyoon7 gabrielyoon7 deleted the feat/566 branch August 17, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielyoon7 gabrielyoon7 gabrielyoon7 approved these changes

@feb-dain feb-dain feb-dain approved these changes

Assignees

@kyw0716 kyw0716

Labels
FE 프론트엔드 관련 이슈입니다 🛠️ 리팩터링 개선사항입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

클라이언트 필터링 컴포넌트를 개선한다
3 participants
@kyw0716 @gabrielyoon7 @feb-dain