Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 빌드시 포함되는 필요없는 패키지들을 정리한다 #603

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

kyw0716
Copy link
Member

@kyw0716 kyw0716 commented Aug 20, 2023

📄 Summary

  • @storybook/react
  • @tanstack/react-query-devtools
  • @testing-library/react
  • @types/jest
  • copy-webpack-plugin
  • file-loader (삭제)
  • jest
  • jest-environment-jsdom
  • msw
  • ts-loader
  • speed-measure-webpack-plugin (속도 측정은 일단 제외시켜봄)
  • husky (삭제)

위 패키지들 devDpendency로 이동시켰습니다.

🕰️ Actual Time of Completion

2시간

🙋🏻 More

- 번들 사이즈 743KB → 389KB로 감소

before

image
image

after

image
image

- 빌드 속도 9초 → 7초로 감소

before

image

after

image

- 배포 시간 약 1분 감소

before

image

after

image

close #602

@kyw0716 kyw0716 added 🛠️ 리팩터링 개선사항입니다 FE 프론트엔드 관련 이슈입니다 labels Aug 20, 2023
@kyw0716 kyw0716 requested a review from feb-dain as a code owner August 20, 2023 05:31
@kyw0716 kyw0716 self-assigned this Aug 20, 2023
@kyw0716 kyw0716 temporarily deployed to test August 20, 2023 05:31 — with GitHub Actions Inactive
@github-actions
Copy link

🚀storybook: https://storybook.carffe.in/

Copy link
Member

@gabrielyoon7 gabrielyoon7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿샷

@kyw0716 kyw0716 merged commit 31ae4a8 into develop Aug 21, 2023
5 checks passed
@kyw0716 kyw0716 deleted the refactor/602 branch August 21, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 관련 이슈입니다 🛠️ 리팩터링 개선사항입니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

빌드시 포함되는 필요없는 패키지들을 정리한다
3 participants