refactor: 혼잡도 그래프의 시멘틱 태그를 progress로 수정한다 #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀storybook: https://storybook.carffe.in/ |
|
🚀storybook: https://storybook.carffe.in/ |
feb-dain
reviewed
Sep 1, 2023
| export const Default = () => { | ||
| return ( | ||
| <> | ||
| {Array.from({ length: 24 }).map((_, index) => ( |
There was a problem hiding this comment.
Array.from 쓰면 map 생략하는 방법 있었죠?
| return ( | ||
| <> | ||
| {Array.from({ length: 24 }).map((_, index) => ( | ||
| <Bar key={index} align={'column'} ratio={(index / 24) * 100} hour={index} /> |
There was a problem hiding this comment.
스토리북 보니까 너무 붙어있어요ㅋㅋㅋ Bar에 column gap 줘야할 것 같아요!
|
|
||
| export const NoRatio = () => { | ||
| return ( | ||
| <> |
| export const NoRatio = () => { | ||
| return ( | ||
| <> | ||
| <Bar align={'column'} ratio={-1} hour={1} /> |
Comment on lines
56
to
59
| border-top-left-radius: 0.4rem; | ||
| border-bottom-left-radius: 0.4rem; | ||
| border-top-right-radius: 1rem; | ||
| border-bottom-right-radius: 1rem; |
|
🚀storybook: https://storybook.carffe.in/ |
feb-dain
approved these changes
Sep 1, 2023
|
🚀storybook: https://storybook.carffe.in/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
🙋🏻 More
close #638