Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: styled-components 의 props 경고를 제거한다 #659

Merged
merged 27 commits into from
Sep 7, 2023

Conversation

gabrielyoon7
Copy link
Member

@gabrielyoon7 gabrielyoon7 commented Sep 6, 2023

📄 Summary

대소문자 관련 오류 메시지 뜨는 현상은 전부 수정했습니다.
설명 드린 것 처럼 $를 간접적으로 사용하는 방식으로 회피했습니다.

  • Wrapper 컴포넌트가 없으면 $로 직접 접근해야합니다. 이는 이후에 개선될 수 있습니다.
  • 웹팩 설정 관련 문제가 있어 스타일드 컴포넌트에서는 전역 경로 접근을 제한합니다.

🕰️ Actual Time of Completion

3시간

🙋🏻 More

boolean 생략 기능은 구현 안했습니다. 이것도 비슷한 방법으로 회피 구현이 가능할 것 같은데 나중에 해결할게요

close #646

TODO: 충전소 리스트를 잘라서 요청하는 기능 구현 필요

[#654]
Co-authored-by: YoungWoo Kim <[email protected]>

[#654]
@gabrielyoon7 gabrielyoon7 self-assigned this Sep 6, 2023
@gabrielyoon7 gabrielyoon7 temporarily deployed to test September 6, 2023 14:39 — with GitHub Actions Inactive
@gabrielyoon7 gabrielyoon7 added 🚑 버그 예기치 않은 문제 또는 의도하지 않은 동작입니다 🛠️ 리팩터링 개선사항입니다 FE 프론트엔드 관련 이슈입니다 labels Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🚀storybook: https://storybook.carffe.in/

Copy link
Member

@kyw0716 kyw0716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹팩 설정은 제가 오늘중으로 고쳐볼게요! 고생하셨습니다~

Comment on lines 1 to 4
// import { getCongestionStatistics } from '@mocks/data';
import type { Meta } from '@storybook/react';

import { ENGLISH_DAYS } from '@constants/congestion';

// import { ENGLISH_DAYS } from '@constants/congestion';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 지워주세요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네?

@gabrielyoon7 gabrielyoon7 temporarily deployed to test September 7, 2023 04:56 — with GitHub Actions Inactive
@gabrielyoon7 gabrielyoon7 merged commit 8462ca0 into develop Sep 7, 2023
2 checks passed
@gabrielyoon7 gabrielyoon7 deleted the refactor/646 branch September 7, 2023 04:56
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🚀storybook: https://storybook.carffe.in/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 관련 이슈입니다 🚑 버그 예기치 않은 문제 또는 의도하지 않은 동작입니다 🛠️ 리팩터링 개선사항입니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styled-components 의 props 경고를 제거한다
3 participants