Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: husky를 개선한다 #886

Merged
merged 5 commits into from
Oct 23, 2023
Merged

refactor: husky를 개선한다 #886

merged 5 commits into from
Oct 23, 2023

Conversation

feb-dain
Copy link
Collaborator

@feb-dain feb-dain commented Oct 19, 2023 •
edited by github-actions bot
Loading

📄 Summary

husky를 잠시 제거했더니 다시 prettier가 적용되지 않은 파일이 올라오는 등 문제가 생겨 husky를 개선해 복원했습니다.

🕰️ Actual Time of Completion

10분

🙋🏻 More

close #885

🚀 Storybook

https://storybook.carffe.in/

@feb-dain feb-dain added 🛠️ 리팩터링 개선사항입니다 FE 프론트엔드 관련 이슈입니다 labels Oct 19, 2023
@feb-dain feb-dain self-assigned this Oct 19, 2023
@feb-dain feb-dain temporarily deployed to test October 19, 2023 08:04 — with GitHub Actions Inactive
@feb-dain feb-dain temporarily deployed to test October 19, 2023 08:18 — with GitHub Actions Inactive
gabrielyoon7
gabrielyoon7 requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@gabrielyoon7 gabrielyoon7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.frontend/readme.md에 기본적인 세팅 방법만 추가해주시면 바로 어프룹 하겠습니다.
이 업데이트는 오늘 할까요? 데모데이 이후에 할까요?

@feb-dain feb-dain temporarily deployed to test October 19, 2023 09:19 — with GitHub Actions Inactive
@feb-dain
Copy link
Collaborator Author

.frontend/readme.md에 기본적인 세팅 방법만 추가해주시면 바로 어프룹 하겠습니다. 이 업데이트는 오늘 할까요? 데모데이 이후에 할까요?

데모데이 이후에 합시다! 그동안 make로 바로 husky 스크립트까지 실행시키는 방법 알아보도록 할게요

@feb-dain feb-dain temporarily deployed to test October 23, 2023 05:32 — with GitHub Actions Inactive
@feb-dain feb-dain merged commit bc59856 into develop Oct 23, 2023
2 checks passed
@feb-dain feb-dain deleted the refactor/885 branch October 23, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielyoon7 gabrielyoon7 gabrielyoon7 approved these changes

@kyw0716 kyw0716 kyw0716 approved these changes

Assignees

@feb-dain feb-dain

Labels
FE 프론트엔드 관련 이슈입니다 🛠️ 리팩터링 개선사항입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

husky를 개선한다
3 participants
@feb-dain @gabrielyoon7 @kyw0716