Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 충전소 리스트에서 로딩을 보여주지 않아도 되는 상황에 보여지는 현상을 개선한다 #923

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: 충전소 리스트에서 로딩을 보여주지 않아도 되는 상황에 보여지는 현상을 개선한다 #923

merged 1 commit into from
Nov 9, 2023

Conversation

gabrielyoon7
Copy link
Member

@gabrielyoon7 gabrielyoon7 commented Nov 9, 2023 •
edited by github-actions bot
Loading

[#922]

📄 Summary

캐시된 충전소 데이터는 재요청하지 않음에도 불구하고 재요청이 되는 것 처럼 보이는 현상을 수정했습니다.

🕰️ Actual Time of Completion

1분

🙋🏻 More

🚀 Storybook

https://storybook.carffe.in/

close #922

@gabrielyoon7 gabrielyoon7 added 🚑 버그 예기치 않은 문제 또는 의도하지 않은 동작입니다 FE 프론트엔드 관련 이슈입니다 labels Nov 9, 2023
@gabrielyoon7 gabrielyoon7 self-assigned this Nov 9, 2023
kyw0716
kyw0716 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@kyw0716 kyw0716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿샷

@gabrielyoon7 gabrielyoon7 merged commit 146c492 into develop Nov 9, 2023
6 checks passed
@gabrielyoon7 gabrielyoon7 deleted the fix/922 branch November 9, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyw0716 kyw0716 kyw0716 approved these changes

@feb-dain feb-dain feb-dain approved these changes

Assignees

@gabrielyoon7 gabrielyoon7

@kyw0716 kyw0716

@feb-dain feb-dain

Labels
FE 프론트엔드 관련 이슈입니다 🚑 버그 예기치 않은 문제 또는 의도하지 않은 동작입니다
Projects
2023-car-ffeine
Status: Done
Milestone
No milestone
3 participants
@gabrielyoon7 @kyw0716 @feb-dain