[BE] feat: Flyway 적용 (#246) #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
xxeol2
approved these changes
Aug 14, 2023
Comment on lines
+1
to
+15
| version: "3.8" | ||
| services: | ||
| db: | ||
| image: mysql:8.0.33 | ||
| container_name: festago-local-db | ||
| restart: always | ||
| ports: | ||
| - "13306:3306" | ||
| environment: | ||
| MYSQL_ROOT_PASSWORD: root | ||
| MYSQL_DATABASE: festago | ||
| MYSQL_USER: festago | ||
| MYSQL_PASSWORD: festago | ||
| TZ: Asia/Seoul | ||
| command: [ "mysqld", "--character-set-server=utf8mb4", "--collation-server=utf8mb4_general_ci" ] |
BGuga
approved these changes
Aug 14, 2023
Comment on lines
+1
to
+15
| version: "3.8" | ||
| services: | ||
| db: | ||
| image: mysql:8.0.33 | ||
| container_name: festago-local-db | ||
| restart: always | ||
| ports: | ||
| - "13306:3306" | ||
| environment: | ||
| MYSQL_ROOT_PASSWORD: root | ||
| MYSQL_DATABASE: festago | ||
| MYSQL_USER: festago | ||
| MYSQL_PASSWORD: festago | ||
| TZ: Asia/Seoul | ||
| command: [ "mysqld", "--character-set-server=utf8mb4", "--collation-server=utf8mb4_general_ci" ] |
There was a problem hiding this comment.
h2 의 문법 문제와 dev, prod 환경과 최대한 비슷한 환경을 local 에서 구성해 보는 것도 큰 장점인 것 같네요!!
|
Validation, Admin 엔티티 추가로 인해 테이블 변경이 있을 것이라 판단하고 올라온 PR 중 DDL 변경이 없을 때 해당 사항 반영 후 머지 하겠습니다! |
# Conflicts: # backend/build.gradle
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
로컬 환경에서는 mysql으로 db를 사용하도록 했습니다.
따라서 mysql을 실행시켜야 로컬 실행이 가능합니다.
docker 디렉터리의 docker-compose.yml을 사용하여 mysql 실행이 가능하니 참고 바랍니다.
테스트 환경에서 h2를 mysql 모드로 실행하여 mysql 문법을 사용할 수 있지만, alter 문에서 일부 문법 호환이 되지 않는 이슈가 있어서, flyway 적용을 하지 않았습니다.
DDL이 현재 #273 이슈 기준 dev 브랜치의 엔티티로 매핑되어 있어 추후 컬럼의 값이 변하면 수정이 필요합니다.