Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 학교 목록 조회 기능 구현 (#431) #432

Merged
merged 3 commits into from
Sep 11, 2023
Merged

[BE] feat: 학교 목록 조회 기능 구현 (#431) #432

merged 3 commits into from
Sep 11, 2023

Conversation

xxeol2
Copy link
Member

@xxeol2 xxeol2 commented Sep 8, 2023

📌 관련 이슈

✨ PR 세부 내용

학생 인증을 위한 학교 목록 조회 기능을 구현했습니다.

@xxeol2 xxeol2 added the BE 백엔드에 관련된 작업 label Sep 8, 2023
@xxeol2 xxeol2 self-assigned this Sep 8, 2023
@xxeol2 xxeol2 linked an issue Sep 8, 2023 that may be closed by this pull request
[BE] 학교 리스트를 조회한다. #431
Closed
@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

Unit Test Results

  62 files    62 suites   11s ⏱️
179 tests 179 ✔️ 0 💤 0 ❌
182 runs  182 ✔️ 0 💤 0 ❌

Results for commit 002e65f.

♻️ This comment has been updated with latest results.

seokjin8678
seokjin8678 requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@seokjin8678 seokjin8678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

누락된 사항에 대해 리뷰 남겼습니다!

backend/src/main/java/com/festago/application/SchoolService.java Show resolved Hide resolved
carsago
carsago approved these changes Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@carsago carsago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간결하네요. 하 가위바위보 잘 할 걸

seokjin8678
seokjin8678 approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@seokjin8678 seokjin8678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영 확인했습니다!

@seokjin8678 seokjin8678 merged commit ba9b4a9 into dev Sep 11, 2023
3 checks passed
@seokjin8678 seokjin8678 deleted the feat/#431 branch September 11, 2023 08:43
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@xxeol2 @BGuga
[BE] feat: 학교 목록 조회 기능 구현 (#431) (#432)
97965e1 
* feat: School 목록 조회 기능 구현

* feat: School 목록 조회 API 구현

* feat: Transactional(readonly=true) 적용
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@xxeol2 @BGuga
[BE] feat: 학교 목록 조회 기능 구현 (#431) (#432)
f306d5c 
* feat: School 목록 조회 기능 구현

* feat: School 목록 조회 API 구현

* feat: Transactional(readonly=true) 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsago carsago carsago approved these changes

@seokjin8678 seokjin8678 seokjin8678 approved these changes

@BGuga BGuga Awaiting requested review from BGuga

Assignees

@xxeol2 xxeol2

@BGuga BGuga

Labels
BE 백엔드에 관련된 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 학교 리스트를 조회한다.
4 participants
@xxeol2 @carsago @seokjin8678 @BGuga