[BE] feat: AppleOpenId 로직 리팩터링(#975) #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results241 files 241 suites 28s ⏱️ Results for commit ecb8c2a. ♻️ This comment has been updated with latest results. |
seokjin8678
requested changes
May 16, 2024
Comment on lines
11
to
30
| @DisplayNameGeneration(ReplaceUnderscores.class) | ||
| @SuppressWarnings("NonAsciiCharacters") | ||
| class AppleOpenIdPublicKeyLocatorTest extends ApplicationIntegrationTest { | ||
|
|
||
| @Autowired | ||
| AppleOpenIdPublicKeyLocator appleOpenIdPublicKeyLocator; | ||
|
|
||
| @Autowired | ||
| KakaoOpenIdPublicKeyLocator kakaoOpenIdPublicKeyLocator; | ||
|
|
||
| @Test | ||
| void 소셜별_Locator_들은_캐싱을_공유하지_않는다() { | ||
|
|
||
| // given & when & then | ||
| assertThat(appleOpenIdPublicKeyLocator) | ||
| .usingRecursiveComparison() | ||
| .comparingOnlyFields("cachedOpenIdKeyProvider") | ||
| .isNotEqualTo(kakaoOpenIdPublicKeyLocator); | ||
| } | ||
| } |
There was a problem hiding this comment.
비즈니스 로직의 검증이 아닌, 스프링 프레임워크의 동작에 대한 검증 테스트 같네요!
해당 테스트가 필요하다고 생각하신 이유가 있을까요?
There was a problem hiding this comment.
사실 필요없지만 prototype을 직접 사용한건 처음이라 한번 검증차에서 구현해본 것을 남겼습니다!!
검증 됬으니 지우겠습니다!
seokjin8678
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
해당 PR 리뷰 적용하였습니다