신고 조치 기능 구현 #770
Merged
신고 조치 기능 구현 #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woo-chang
approved these changes
Oct 18, 2023
| @ApiResponse( | ||
| responseCode = "400", | ||
| description = """ | ||
| 1.신고 ID가 양의 정수가 아닌 경우 |
There was a problem hiding this comment.
신고 ID가 존재하지 않은 경우에도 400 예외가 발생할 수 있을 것 같아요 !
| List<ReportAggregateDto> findReportsGroupedByReportTypeAndTargetId(final Pageable pageable); | ||
| List<ReportAggregateDto> findReportAggregateDtosByReportTypeAndTargetId(final Pageable pageable); | ||
|
|
||
| Optional<ReportAggregateDto> findReportAggregateDtoByReportTypeAndTargetId(ReportType reportType, Long targetId); |
| @@ -13,6 +14,8 @@ public interface ReportStrategy { | |||
|
|
|||
| String parseTarget(Long targetId); | |||
|
|
|||
| void reportAction(ReportAggregateDto reportAggregateDto); | |||
jeomxon
requested changes
Oct 18, 2023
Comment on lines
30
to
36
| public void reportAction(final ReportActionRequest request) { | ||
| final Report report = reportRepository.findById(request.id()) | ||
| .orElseThrow(() -> new NotFoundException(ReportExceptionType.NOT_FOUND)); | ||
|
|
||
| final ReportAggregateDto reportAggregateDto = reportRepository | ||
| .findReportAggregateDtoByReportTypeAndTargetId(report.getReportType(), report.getTargetId()) | ||
| .orElseThrow(() -> new NotFoundException(ReportExceptionType.NOT_FOUND)); |
There was a problem hiding this comment.
Q
이 두 상황에서 같은 예외를 사용하는 이유가 무엇인가요?
There was a problem hiding this comment.
먼저 저 두 단계를 거칠 필요가 있었습니다. 결국 reportType과 targetId로 group by 해서 가져와야 해서요.
그래서 이처럼 2번 가져오게 되었는데, 결국 id로든 reportType과 targetId 로든 결국 찾아오려고 하는데 못찾아오는 거면 NotFoundException이 맞다고 판단했습니다. 또한 둘 다 Report에 관련한 것들이니 ReportExceptionType을 사용하였습니다.
There was a problem hiding this comment.
예외 메시지가 같은데, 예외가 발생한 경우 응답과 로그를 통해서 찾기 어렵지 않을까요?
There was a problem hiding this comment.
그러게요. ReportAggregateDto에 관한 message를 따로 만들어볼게요.
aiaiaiai1
approved these changes
Oct 18, 2023
Comment on lines
94
to
135
| @Test | ||
| @DisplayName("신고 조치 예정 정보를 조회한다") | ||
| void getReportAggregateDto() { | ||
| // given | ||
| Member memberA = memberRepository.save(MemberFixtures.MALE_30.get()); | ||
| Member memberB = memberRepository.save(MemberFixtures.MALE_20.get()); | ||
|
|
||
| final ReportType reportType = ReportType.POST; | ||
| final long targetId = 1L; | ||
|
|
||
| final String reasonA = "reasonA"; | ||
| reportTestPersister.builder() | ||
| .member(memberA) | ||
| .reportType(reportType) | ||
| .reason(reasonA) | ||
| .targetId(targetId) | ||
| .save(); | ||
|
|
||
| final String reasonB = "reasonB"; | ||
| Report savedReportB = reportTestPersister.builder() | ||
| .member(memberB) | ||
| .reportType(reportType) | ||
| .reason(reasonB) | ||
| .targetId(targetId) | ||
| .save(); | ||
|
|
||
| // when | ||
| ReportAggregateDto reportAggregateDto = reportCustomRepository | ||
| .findReportAggregateDtoByReportTypeAndTargetId(reportType, targetId) | ||
| .orElseThrow(() -> new NotFoundException(ReportExceptionType.NOT_FOUND)); | ||
|
|
||
| // then | ||
| assertSoftly(softly -> { | ||
| softly.assertThat(reportAggregateDto.reportMaxId()).isEqualTo(savedReportB.getId()); | ||
| softly.assertThat(reportAggregateDto.reportType()).isEqualTo(reportType); | ||
| softly.assertThat(reportAggregateDto.targetId()).isEqualTo(targetId); | ||
| softly.assertThat(reportAggregateDto.reasons()).contains(reasonA, reasonB); | ||
| softly.assertThat(reportAggregateDto.createdAt().truncatedTo(ChronoUnit.SECONDS)) | ||
| .isEqualTo(savedReportB.getCreatedAt().truncatedTo(ChronoUnit.SECONDS)); | ||
| }); | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
close: #757
📝 작업 요약
신고 조치 기능 구현
⏰ 소요 시간
7시간
🔎 작업 상세 설명
신고 조치 기능 구현할 때 조치 확정과 조치 기각으로 나뉜다.