Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

배포 전 여러가지 버그 수정 #794

Merged
merged 3 commits into from
Oct 19, 2023
Merged

배포 전 여러가지 버그 수정 #794

merged 3 commits into from
Oct 19, 2023

Conversation

tjdtls690
Copy link
Collaborator

@tjdtls690 tjdtls690 commented Oct 19, 2023 •
edited
Loading

🔥 연관 이슈

close: #793

📝 작업 요약

  1. reponse 변수명 수정
  2. GET /notices 요청 시 필터 안거치도록 수정
  3. 댓글 작성 시 게시글 작성자에게 알림 추가하는 로직 수정
  4. @jsonformat 어노테이션 추가

@tjdtls690 tjdtls690 self-assigned this Oct 19, 2023
woo-chang
woo-chang approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@woo-chang woo-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체고에요 ✅

aiaiaiai1
aiaiaiai1 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@aiaiaiai1 aiaiaiai1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍 👍 👍 👍 👍 👍 👍

jeomxon
jeomxon approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@jeomxon jeomxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎㅎ

@github-actions
Copy link

Test Results

490 tests   489 ✔️  31s ⏱️
156 suites      1 💤
156 files        0 ❌

Results for commit db61465.

@tjdtls690 tjdtls690 merged commit f312b9c into dev Oct 19, 2023
4 checks passed
@tjdtls690 tjdtls690 deleted the refactor/#793 branch October 19, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeomxon jeomxon jeomxon approved these changes

@woo-chang woo-chang woo-chang approved these changes

@aiaiaiai1 aiaiaiai1 aiaiaiai1 approved these changes

Assignees

@tjdtls690 tjdtls690

Labels
BE 🐛 버그
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

response 변수명 변경
4 participants
@tjdtls690 @jeomxon @woo-chang @aiaiaiai1