[BE] 체크리스트 목록 조회 시 지하철 json 형태를 변경한다. #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JINU-CHANG
requested changes
Oct 24, 2024
| return ChecklistPreviewResponseV1.of(checklist, stationResponse, isLiked); | ||
| } | ||
|
|
||
| private SubwayStationResponse readNearstStation(Checklist checklist) { |
There was a problem hiding this comment.
Suggested change
| private SubwayStationResponse readNearstStation(Checklist checklist) { | |
| private SubwayStationResponse readNearestStation(Checklist checklist) { |
Comment on lines
233
to
240
| List<ChecklistStation> checklistStations = checklistStationService.readChecklistStationsByChecklist(checklist); | ||
| if (checklistStations.isEmpty()) { | ||
| return null; | ||
| } | ||
|
|
||
| List<SubwayStationResponse> stationResponses = checklistStations.stream() | ||
| .map(SubwayStationResponse::from) | ||
| .toList(); |
There was a problem hiding this comment.
SubwayStationResponses가 생성 책임을 가지고 있어도 되지 않을까요?
There was a problem hiding this comment.
일단 반영했는데, 요청하신 게 맞는지 잘 모르겠네요...
There was a problem hiding this comment.
checkliststations 스트림으로 돌면서 생성하는 로직 말한거였어요 ..! from이 checkliststation 도메인을 받아서 생성하면 코드가 더 깔끔해질 것 같아요
There was a problem hiding this comment.
우주) 이미 from(LIst) 메서드가 있어서 추가로 from(List) 메서드를 선언해줄 수 없었습니다!
나중에 개선 방식을 생각해볼게요!
JINU-CHANG
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타