Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 방 설정 변경에 검증 로직 추가 #219

Merged
merged 6 commits into from
Aug 20, 2024
Merged

[FEAT] 방 설정 변경에 검증 로직 추가 #219

merged 6 commits into from
Aug 20, 2024

Conversation

PgmJun
Copy link
Member

@PgmJun PgmJun commented Aug 20, 2024

Issue Number

#215

As-Is

  • 방 설정 변경 검증 기준이 변경되었다.
  • 방 설정에 대한 검증로직이 방 설정 클래스가 아닌 방에 존재한다.

To-Be

  • 방 설정 변경 검증 기준을 변경한다.
    • 방 시간제한 5,10,15초
    • 방 라운드 제한 3~10 라운드
  • 방 설정에 대한 검증로직이 방 설정 클래스(RoomSetting)로 이동
    • RoomTest에 존재하던 방 설정 값 변경 테스트 RoomSettingTest로 이동

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

image

(Optional) Additional Description

  • RoomService의 getRoom 메서드가 @Transactional 로 설정되어 있어서 ReadOnly로 변경해주었습니다.

@PgmJun PgmJun added ♻️ refactor 리팩토링 ✨ feat 기능 추가 🍃 BE back end labels Aug 20, 2024
@PgmJun PgmJun added this to the BE Sprint4 milestone Aug 20, 2024
@PgmJun PgmJun self-assigned this Aug 20, 2024
Copy link
Member

@jhon3242 jhon3242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~ 수고했어요 든든

Copy link
Contributor

@leegwichan leegwichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!!

Copy link
Member

@GIVEN53 GIVEN53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@@ -19,7 +19,7 @@ public Room createRoom() {
return roomRepository.save(Room.createNewRoom());
}

@Transactional
@Transactional(readOnly = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사해용 ~

@PgmJun PgmJun merged commit 3e9c7bc into develop Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 BE back end ✨ feat 기능 추가 ♻️ refactor 리팩토링
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants