Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 방장이 아닌 사용자가 카운트다운 후 게임 시작 안되는 오류 해결 #294

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

rbgksqkr
Copy link
Contributor

@rbgksqkr rbgksqkr commented Sep 25, 2024

Issue Number

#293

As-Is

  • 카운트다운 후 방장만 화면이 전환됨

To-Be

  • 다른 사용자들도 카운트다운 진행

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

default.mov

(Optional) Additional Description

🌸 Storybook 배포 주소

https://woowacourse-teams.github.io/2024-ddangkong/storybook/

@rbgksqkr rbgksqkr added 🛠 fix 버그 🫧 FE front end 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) labels Sep 25, 2024
@rbgksqkr rbgksqkr added this to the FE Sprint5 milestone Sep 25, 2024
@rbgksqkr rbgksqkr self-assigned this Sep 25, 2024
Copy link
Contributor

@novice0840 novice0840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하게 버그 잘 찾았네요!!

방장이 버튼 클릭 시 startCountdown 함수 호출에서
-> API polling에서 gameStart가 true 인 경우 startCountdown 함수 호출로 바뀌었네요

Comment on lines 35 to 38
const handleGameStart = () => {
if (memberInfo.isMaster) {
startGameMutation.mutate();
startCountdown();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌸 칭찬 🌸

그렇네요, 이렇게하면 master 일때만 startCountdown() 함수가 실행되겠군요

@rbgksqkr rbgksqkr merged commit a4c07d7 into develop Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) 🫧 FE front end 🛠 fix 버그
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FIX] 방장이 아닌 사용자가 카운트다운 후 게임 시작 안되는 오류 해결
2 participants