[REFACTOR] 접근성 컴포넌트 A11yOnly 리팩토링 및 추가 접근성 코드 리팩토링 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rbgksqkr
approved these changes
Oct 22, 2024
| @@ -25,7 +25,7 @@ describe('SelectContainer', () => { | |||
|
|
|||
| customRender(<SelectContainer />); | |||
|
|
|||
| const optionButton = await screen.findByRole('button', { name: SELECT_OPTION }); | |||
| const optionButton = await screen.findByRole('radio', { name: SELECT_OPTION }); | |||
There was a problem hiding this comment.
🌸 칭찬 🌸
지렸다 radiogrup하고 radio 하면 몇번째 중 몇번째가 떠서 좋은 것 같아요!
| @@ -31,6 +31,7 @@ const Timer = ({ selectedId, isVoted, completeSelection }: TimerProps) => { | |||
| isVoted, | |||
| completeSelection, | |||
| }); | |||
| const ScreenReaderLeftRoundTime = `${leftRoundTime}초 남았습니다.`; | |||
There was a problem hiding this comment.
💭 질문 💭
카멜 케이스가 아닌 파스칼 케이스를 사용한 이유가 있을까요?
const ScreenReaderLeftRoundTime = `${leftRoundTime}초 남았습니다.`;There was a problem hiding this comment.
허걱쓰 ! 수정하고 머지하겠습니다 ^ .^
| css={SelectOptionLayout(selectedId === option.optionId, isCompleted)} | ||
| onClick={() => handleClickOption(option.optionId)} | ||
| disabled={isCompleted} | ||
| aria-pressed={selectedId === option.optionId} | ||
| aria-checked={selectedId === option.optionId} |
There was a problem hiding this comment.
🌸 칭찬 🌸
오우 radio로 바꾸니까 checked로 되는군요 굿굿
novice0840
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#361
As-Is
To-Be
A11yOnly
게임 타이머
대기 방 인원
게임 선택지
Check List
Test Screenshot
(Optional) Additional Description
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alert_role
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/status_role
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/radio_role
🌸 Storybook 배포 주소