Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 방 나갈 때 쿠키 삭제 추가 #374

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[FIX] 방 나갈 때 쿠키 삭제 추가 #374

merged 2 commits into from
Oct 24, 2024

Conversation

jhon3242
Copy link
Member

Issue Number

close #371

As-Is

  • 방을 나갈 때 쿠키가 삭제되지 않았음

To-Be

  • 방 나갈 때 max-age를 0으로 설정하여 쿠키 삭제

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

image

(Optional) Additional Description

@jhon3242 jhon3242 added 🛠 fix 버그 🍃 BE back end 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) labels Oct 24, 2024
@jhon3242 jhon3242 self-assigned this Oct 24, 2024
GIVEN53
GIVEN53 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@GIVEN53 GIVEN53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 fix goooooooooooood

@jhon3242 jhon3242 merged commit 86ab594 into develop Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leegwichan leegwichan leegwichan approved these changes

@GIVEN53 GIVEN53 GIVEN53 approved these changes

@PgmJun PgmJun Awaiting requested review from PgmJun

Assignees

@jhon3242 jhon3242

Labels
🍃 BE back end 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) 🛠 fix 버그
Projects
2024-ddangkong
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 쿠키 삭제 추가
3 participants
@jhon3242 @leegwichan @GIVEN53