Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Nickname 검증 규칙 수정 #385

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[REFACTOR] Nickname 검증 규칙 수정 #385

merged 2 commits into from
Oct 24, 2024

Conversation

PgmJun
Copy link
Member

@PgmJun PgmJun commented Oct 24, 2024

Issue Number

#383

As-Is

닉네임 길이 검증을 1자부터 12자로 설정해야한다.
이때 Null, Blank 등에 대한 제한도 함께 수행하도록 검증로직을 변경해야한다.

To-Be

  • 닉네임 정책 2~12자 -> 1~12자 로 변경
  • 공백, Null 제한 설정

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

스크린샷 2024-10-24 21 16 04

(Optional) Additional Description

@PgmJun PgmJun added ♻️ refactor 리팩토링 🍃 BE back end labels Oct 24, 2024
@PgmJun PgmJun added this to the BE Sprint6 milestone Oct 24, 2024
@PgmJun PgmJun self-assigned this Oct 24, 2024
Copy link
Member

@GIVEN53 GIVEN53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 fix goooooooooooooooood 👍🏻

Copy link
Contributor

@leegwichan leegwichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@PgmJun PgmJun added the 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) label Oct 24, 2024
@PgmJun PgmJun merged commit 1b4aaa4 into develop Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 BE back end 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) ♻️ refactor 리팩토링
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants