[BE] refactor: Club 매핑 테이블 엔티티 연관 관계 개선 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ehtjsv2
approved these changes
Jul 22, 2024
| private List<String> collectOverviewPetImages(Club club) { | ||
| Map<Long, List<Pet>> groupPetsByMemberId = clubPetRepository.findAllByClubId(club.getId()).stream() | ||
| .map(ClubPet::getPet) | ||
| .collect(Collectors.groupingBy(pet -> pet.getMember().getId())); |
takoyakimchi
approved these changes
Jul 22, 2024
Comment on lines
26
to
29
| @ManyToOne(optional = false, fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "club_member_id", nullable = false) | ||
| private ClubMember clubMember; | ||
| @JoinColumn(name = "club_id", nullable = false) | ||
| private Club club; | ||
|
|
Comment on lines
51
to
55
| ClubMember clubMember = ClubMember.builder() | ||
| .member(member) | ||
| .club(club) | ||
| .build(); | ||
|
|
There was a problem hiding this comment.
clubMember는 member, club 순으로 생성하고
clubPet은 club, pet 순으로 생성하고 있네요.
빌더 패턴을 쓴다고 하더라도, 하나로 통일시키면 좋을 것 같아요!
| "https://image.com"); | ||
|
|
||
| protected Club saveNewClub() { | ||
| protected Club getSavedClub(Set<Gender> genders, Set<SizeType> sizes) { |
There was a problem hiding this comment.
Suggested change
| protected Club getSavedClub(Set<Gender> genders, Set<SizeType> sizes) { | |
| protected Club createClub(Set<Gender> genders, Set<SizeType> sizes) { |
메서드명은 get으로 되어 있지만 내부적으로는 생성도 하고 있네요.
create라는 이름은 어떨까요?
|
|
||
| List<FindSearchingClubResponse> responses = clubQueryService.findSearching(request); | ||
|
|
||
| assertThat(responses.isEmpty()).isTrue(); |
There was a problem hiding this comment.
Suggested change
| assertThat(responses.isEmpty()).isTrue(); | |
| assertThat(responses).isEmpty(); |
Comment on lines
+55
to
+63
| private List<String> collectOverviewPetImages(Club club) { | ||
| Map<Long, List<Pet>> groupPetsByMemberId = clubPetRepository.findAllByClubId(club.getId()).stream() | ||
| .map(ClubPet::getPet) | ||
| .collect(Collectors.groupingBy(pet -> pet.getMember().getId())); | ||
|
|
||
| return groupPetsByMemberId.values().stream() | ||
| .map(petList -> petList.get(0).getImageUrl().getValue()) | ||
| .collect(toList()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| private List<String> collectOverviewPetImages(Club club) { | |
| Map<Long, List<Pet>> groupPetsByMemberId = clubPetRepository.findAllByClubId(club.getId()).stream() | |
| .map(ClubPet::getPet) | |
| .collect(Collectors.groupingBy(pet -> pet.getMember().getId())); | |
| return groupPetsByMemberId.values().stream() | |
| .map(petList -> petList.get(0).getImageUrl().getValue()) | |
| .collect(toList()); | |
| } | |
| private List<String> findPetImageUrls(Club club) { | |
| Map<Long, List<Pet>> groupPetsByMemberId = clubPetRepository.findAllByClubId(club.getId()).stream() | |
| .map(ClubPet::getPet) | |
| .collect(groupingBy(pet -> pet.getMember().getId())); | |
| return groupPetsByMemberId.values().stream() | |
| .map(petList -> petList.get(0).getImageUrl().getValue()) | |
| .toList(); | |
| } |
- 메서드 이름이 더 직관적이면 좋겠어요. overview는 전체 펫의 요약이라는 느낌이 들어서요.
- 불변 리스트로 리턴하면 더 좋겠네요!
J-I-H-O
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
리뷰 요청 사항 (없으면 삭제해 주세요)
전달 사항 (없으면 삭제해 주세요)