멍개 리스트 UI 구현 #48
Closed
멍개 리스트 UI 구현 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junjange
reviewed
Jul 14, 2024
Comment on lines
29
to
34
| <TextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:textColor="@color/black" | ||
| android:textSize="18sp" | ||
| tools:text="잠실6동" /> |
There was a problem hiding this comment.
styles에 가보면 font, textSize, color 등으로 만들어 놓은 text style이 있는데 그거 보고 사용하면 좋을 것 같아요!!
There was a problem hiding this comment.
웁스~ 나중에 봤네요.
일단 제거하고 ui 구체화 이슈에서 적용해보겠습니다 ~
junjange
requested changes
Jul 14, 2024
gaeun5744
requested changes
Jul 14, 2024
Comment on lines
25
to
28
| companion object { | ||
| const val GENDER_FILTER_SUBJECT = "성별" | ||
| const val SIZE_FILTER_SUBJECT = "사이즈" | ||
| } |
There was a problem hiding this comment.
이거 string.xml으로 빼는 방법도 고민하면 좋을거 같아요😥
Comment on lines
17
to
26
| class SizeFilter(filterName: String) : GroupFilter(filterName) { | ||
| companion object { | ||
| private fun from(): List<GroupFilter> { | ||
| return listOf( | ||
| SizeFilter("수컷"), | ||
| SizeFilter("암컷"), | ||
| SizeFilter("중성화 수컷"), | ||
| SizeFilter("중성화 암컷"), | ||
| ) | ||
| } |
There was a problem hiding this comment.
사이즈 필터라고 되어 있는데, 일단 더미데이터로 성별 string을 넣을건가요?
There was a problem hiding this comment.
요거는 다른 사람들도 쓸 수 있도록 컨벤션 맞추면 좋을거 같아요!!
혹시 컨벤션 바꾸고 싶으면 언제든 말씀해주세용
There was a problem hiding this comment.
요게 아니였군요!
내일 수정해볼께요
|
저도 에디처럼 model 패키지 만드는거 완전 찬성입니다!! 너무 수고많으셨어요 |
dpcks0509
approved these changes
Jul 14, 2024
Comment on lines
+7
to
+8
| var participationFilter = ParticipationFilter.POSSIBLE | ||
| private set |
Comment on lines
+8
to
+11
| GenderFilter("수컷"), | ||
| GenderFilter("암컷"), | ||
| GenderFilter("중성화 수컷"), | ||
| GenderFilter("중성화 암컷"), |
There was a problem hiding this comment.
하드코딩된 문자열을 상수나 다른 방법으로 처리해도 좋을 것 같아요!
Comment on lines
+21
to
+28
| <include | ||
| android:id="@+id/participation_filter" | ||
| layout="@layout/include_group_filter" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| app:filterName="@{groupFilterSelector.participationFilter.filterName}" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> |
There was a problem hiding this comment.
include를 활용한 view 재사용 좋은 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항