[BE] fix: 발자국 알림 개선 #505
Merged
[BE] fix: 발자국 알림 개선 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Test Results161 tests +158 161 ✅ +158 18s ⏱️ +18s Results for commit 53a8a0d. ± Comparison against base commit 93e3951. This pull request removes 3 and adds 161 tests. Note that renamed tests count towards both. |
jimi567
approved these changes
Aug 21, 2024
Comment on lines
+30
to
+38
| @DisplayName("알림을 받을 디바이스가 존재하지 않으면 알림을 보내지 않습니다.") | ||
| @Test | ||
| void sendFootprintNotification() throws FirebaseMessagingException { | ||
| // when | ||
| fcmNotificationService.sendFootprintNotification("title", "content", List.of()); | ||
|
|
||
| // then | ||
| verify(firebaseMessaging, never()).sendEachForMulticast(any()); | ||
| } |
There was a problem hiding this comment.
오 검증문이 특이하네요 mockito 기능인가요?!
takoyakimchi
approved these changes
Aug 21, 2024
| private final DeviceTokenRepository deviceTokenRepository; | ||
|
|
||
| public FcmNotificationService( | ||
| FirebaseApp firebaseApp, | ||
| @Autowired FirebaseApp firebaseApp, |
There was a problem hiding this comment.
이거 어노테이션 붙여야 하나요? 필드에 없는 값이면 붙여야 하는 건가...?
Comment on lines
+39
to
+44
| public void sendFootprintNotification(String title, String content, String receiverToken) { | ||
| Map<String, String> data = Map.of( | ||
| "body", content | ||
| ); | ||
|
|
||
| sendNotificationWithType(FOOTPRINT, title, data, List.of(receiverToken)); |
There was a problem hiding this comment.
오 제가 만든 메서드 잘 활용해주셨네용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항