[BE] 모임 필터 리스트 정렬 추가 #535
Merged
[BE] 모임 필터 리스트 정렬 추가 #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results162 tests 162 ✅ 19s ⏱️ Results for commit 39f9234. |
ehtjsv2
approved these changes
Sep 3, 2024
| @@ -87,9 +88,11 @@ public class Club { | |||
| private Status status; | |||
|
|
|||
| @OneToMany(mappedBy = "clubMemberId.club", orphanRemoval = true, cascade = CascadeType.ALL) | |||
| @OrderBy("createdAt") | |||
There was a problem hiding this comment.
나중에 페이징 추가하면 batchsize로 바꿀 예정이라 없앨 수 있을것 같슴당.
| private Set<ClubMember> clubMembers = new HashSet<>(); | ||
|
|
||
| @OneToMany(mappedBy = "clubPetId.club", orphanRemoval = true, cascade = CascadeType.ALL) | ||
| @OrderBy |
There was a problem hiding this comment.
Order할 element를 지정하지 않으면 primaryKey로 하는 군요~!
takoyakimchi
approved these changes
Sep 3, 2024
Comment on lines
25
to
26
|
|
||
| // hello | ||
| public ChatRoomController( |
J-I-H-O
approved these changes
Sep 4, 2024
J-I-H-O
approved these changes
Sep 4, 2024
Comment on lines
-239
to
+241
| clubPets.removeAll(participatingMemberPets); | ||
| // participatingMemberPets.forEach(clubPet -> clubPet.updateClub(null)); | ||
| participatingMemberPets.forEach(clubPets::remove); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
리뷰 요청 사항 (없으면 삭제해 주세요)
전달 사항 (없으면 삭제해 주세요)