[BE] feat: 놀이터 참여하기 #637
Merged
[BE] feat: 놀이터 참여하기 #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…course-teams/2024-friendogly into feature/be-playground-post
takoyakimchi
requested changes
Oct 18, 2024
Comment on lines
151
to
154
|
|
||
| // then | ||
| assertThat(isPlaygroundMemberPresent).isFalse(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| // then | |
| assertThat(isPlaygroundMemberPresent).isFalse(); | |
| } | |
| // then | |
| assertThat(playgroundMemberRepository.findById(playgroundMember.getId())).isEmpty(); | |
| } |
Comment on lines
97
to
103
| double latitude299mFromA = GeoCalculator.calculateLatitudeOffset(latitudeA, 299); | ||
| double latitude299mFromA = GeoCalculator.calculateLatitudeOffset(latitudeA, 1); |
Comment on lines
351
to
353
|
|
||
| @DisplayName("놀이터에 참여한 멤벙 메세지 수정") | ||
| @Test |
Comment on lines
258
to
260
| 1, | ||
| List.of("url1", "url2", "url3") | ||
| ); |
There was a problem hiding this comment.
문서화가 좀 더 친절하면 좋을듯해요!!
URL 형식으로 넣어주면 어떨까요??
Comment on lines
25
to
26
| private static final int MAX_PET_IMAGE_COUNT = 5; | ||
|
|
There was a problem hiding this comment.
Suggested change
| private static final int MAX_PET_IMAGE_COUNT = 5; | |
| private static final int MAX_PET_PREVIEW_IMAGE_COUNT = 5; | |
상수이름 제안입니다
Comment on lines
3
to
7
| public record UpdatePlaygroundMemberMessageRequest( | ||
| String message //todo: 검증추가 | ||
| ) { | ||
|
|
||
| } |
takoyakimchi
previously approved these changes
Oct 18, 2024
| petImages = cutPeImagesCount(petImages); | ||
| petImages = cutPetImagesCount(petImages); |
J-I-H-O
approved these changes
Oct 18, 2024
Comment on lines
+123
to
+125
| if (!isInsideBoundary) { | ||
| playgroundMember.updateExitTime(LocalDateTime.now()); | ||
| } |
There was a problem hiding this comment.
사용자가 놀이터에 도착한 이력이 없더라도 놀이터 범위 밖에서 update API를 호출하면 exitTime이 갱신되네요!
지금은 문제가 없겠지만, 추후에 exitTime으로 무언가 처리하는 로직이 추가된다면 문제가 생길 수도 있다는걸 인지하는게 좋겠어요.
Comment on lines
+63
to
+66
| playgroundPetDetails.sort(Comparator | ||
| .comparing(PlaygroundPetDetail::isMine).reversed() | ||
| .thenComparing(Comparator.comparing(PlaygroundPetDetail::isArrival).reversed()) | ||
| ); |
There was a problem hiding this comment.
좋네요! 그런데 두개의 Comparator의 개행을 맞춰주면 더 가독성이 올라갈 것 같아요~
J-I-H-O
requested changes
Oct 18, 2024
Comment on lines
123
to
124
| petImages = cutPetImagesCount(petImages); | ||
| } |
There was a problem hiding this comment.
Suggested change
| petImages = cutPetImagesCount(petImages); | |
| } | |
| } | |
| petImages = cutPetImagesCount(petImages); |
takoyakimchi
approved these changes
Oct 18, 2024
J-I-H-O
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항