♻️ nullify binding object on onDestroyView callback

woowacourse-teams · Jul 25, 2024 · 67f2484 · 67f2484
1 parent d7e823f
commit 67f2484
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/android/app/src/main/java/net/pengcook/android/presentation/onboarding/OnboardingFragment.kt b/android/app/src/main/java/net/pengcook/android/presentation/onboarding/OnboardingFragment.kt
@@ -59,6 +59,11 @@ class OnboardingFragment : Fragment() {
         }
     }
 
+    override fun onDestroyView() {
+        super.onDestroyView()
+        _binding = null
+    }
+
     private fun handleGoogleSignInResult(task: Task<GoogleSignInAccount>) {
         try {
             val account = task.getResult(ApiException::class.java)

diff --git a/android/app/src/main/java/net/pengcook/android/presentation/signup/SignUpFragment.kt b/android/app/src/main/java/net/pengcook/android/presentation/signup/SignUpFragment.kt
@@ -54,8 +54,8 @@ class SignUpFragment : Fragment() {
         }
     }
 
-    override fun onDestroy() {
-        super.onDestroy()
+    override fun onDestroyView() {
+        super.onDestroyView()
         _binding = null
     }
 
@@ -75,7 +75,7 @@ class SignUpFragment : Fragment() {
             ArrayAdapter(
                 requireContext(),
                 android.R.layout.simple_spinner_item,
-                List(100) { (it + 1820).toString() },
+                List(100) { (it + 1920).toString() },
             )
         yearAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item)
         binding.formBirthDate.spFormContent1.spDefault.adapter = yearAdapter