Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ erase comment count & toast message #387

Merged
merged 4 commits into from
Oct 8, 2024
Merged

♻️ erase comment count & toast message #387

merged 4 commits into from
Oct 8, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 7, 2024

Original issue description

Erase

Comment Count of Comment Fragment
(before) ex. Comment 12
(after) Comment

Toast message when there is no Comment
(before) Toast message : There is no Comments...
(after) no message

closes #386

Comment Count of Comment Fragment
(before) ex. Comment 12
(after) Comment
empty state control is no more needed -> deleted
(before) Toast message : There is no Comments...
(after) no message
Copy link
Contributor

@kmkim2689 kmkim2689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

댓글 관련 로직을 개선해주셨네요!
고생 많으셨습니다!!

Copy link

@ii2001 ii2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이상이 없이 깔끔하네요! 머지 하겠습니다!

}
_comments.value =
comments.filter { it.userId !in (blockedUserIds.value ?: emptyList()) }
_comments.value = comments.filter { it.userId !in (blockedUserIds.value ?: emptyList()) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!in 이렇게 표현할수 있다는걸 알았네요!

@ii2001 ii2001 merged commit 75b1c2b into an/dev Oct 8, 2024
2 checks passed
@ii2001 ii2001 deleted the an/feat/386 branch October 8, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AN Android ♻️ refactor refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants