✨ implement category layout #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hogu59
approved these changes
Jul 25, 2024
|
|
||
| class CategoryAdapter( | ||
| private val categoryEventListener: CategoryEventListener, | ||
| ) : ListAdapter<Category, CategoryViewHolder>(diffUtil) { |
| package net.pengcook.android.presentation.category | ||
|
|
||
| interface CategoryEventListener { | ||
| fun onNavigateToRecipesByCategory(categoryId: Long) |
There was a problem hiding this comment.
이 함수는 카테고리가 클릭되었을때 이동하는 내용을 추상화한 함수같은데, 네이밍이 너무 명시적이어서 문제가 될 소지가 있지 않을까 싶습니다.
오히려 추상화를 한다면 행위 자체에 초점을 맞추어 "onCategorySelected"와 같은 네이밍은 어떨까 싶습니다 :)
|
|
||
| override fun onDestroy() { | ||
| super.onDestroy() | ||
| _binding = null |
| val position = parent.getChildAdapterPosition(view) | ||
| val column = position % spanCount | ||
|
|
||
| if (includeEdge) { |
There was a problem hiding this comment.
함수 분리 가능할까요? 좀 길군요..?ㅋㅋ 이중 if로 depth 도 커졌군요...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement category layout