Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.1/AN-REFACTOR] 타입, 배틀 화면 Koin 적용 #415

Merged
merged 33 commits into from
Oct 24, 2024

Conversation

JoYehyun99
Copy link
Contributor

작업한 내용

  • 상성, 배틀 화면 Viewmodel koin 적용 했습니당

PR 포인트

  • 대부분 파라미터가 있어서 어쩔 수 없이 viewModelOf 사용을 못했는데, 오둥이가 언급했었던 다른 방안을 아직 못 찾았어요 🥲
  • 일단은 이 상태로 PR날립니다~

🚀Next Feature

  • 가로 모드 대응

@JoYehyun99 JoYehyun99 self-assigned this Oct 24, 2024
@github-actions github-actions bot added AN_REFACTOR ✍️ 안드로이드 리팩토링 v1.1.1 🏷️ labels Oct 24, 2024
Copy link
Contributor

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 예니 👍

다만, 다음 작업들이 추가되어야할 것 같아요!

  1. FakeBattleRepository를 DefaultRepository 처럼 단순 반환값만 있는 것이 아니라 로직 수행할 수 있도록 개선
  2. Fragment 테스트

@JoYehyun99 JoYehyun99 merged commit a7fb157 into an/develop Oct 24, 2024
2 checks passed
@JoYehyun99 JoYehyun99 deleted the an/refactor/di branch October 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AN_REFACTOR ✍️ 안드로이드 리팩토링 v1.1.1 🏷️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants