-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] feat : 회원용 리뷰 그룹 생성 API 연결 및 관련 목서버 셋팅 수정 #1072
Open
BadaHertz52
wants to merge
14
commits into
develop
Choose a base branch
from
fe/feat/1068-loggined-review-group-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined-review-group-api
…ined-review-group-api
- apis/group.ts -> types
BadaHertz52
changed the title
Fe/feat/1068 loggined review group api
[FE] feat : 회원용 리뷰 그룹 생성 API 연결 및 관련 목서버 수정
Jan 23, 2025
BadaHertz52
changed the title
[FE] feat : 회원용 리뷰 그룹 생성 API 연결 및 관련 목서버 수정
[FE] feat : 회원용 리뷰 그룹 생성 API 연결 및 관련 목서버 셋팅 수정
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
isMemeber
를 사용해, 회원여부에 따라 다른 데이터를 사용해 API 요청revieweeId
로 회원이 만든 리뷰 그룹인지 내려주고 있기 때문에, 리뷰 연결 페이지로 연결되는 리뷰 링크는 그대로 유지회원용 리뷰 그룹 생성 시 화면
비회원용 리뷰 그룹 생성 시 화면
회원용/비회원용 reviewRequestCode 분리한 이유
상황 :
분리한 이유 :
기대하는 바 :
추가 내용 :
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말