-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVC 구현하기 - 1단계] 이리내(성채연) 미션 제출합니다. #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 이리내! 마코입니다.
깔끔하게 잘 구현해주셨고 부족한 부분도 딱히 안보여서 간단한 코멘트와 함께 머지하겠습니다!
다음 단계 기다리겠습니다~
final MyTest myTest = method.getAnnotation(MyTest.class); | ||
if(myTest != null) { | ||
method.invoke(junit4Test); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (method.isAnnotationPresent(MyTest.class)) {
method.invoke(junit4Test);
}
이렇게도 사용할 수 있습니다
@@ -21,9 +28,55 @@ public AnnotationHandlerMapping(final Object... basePackage) { | |||
|
|||
public void initialize() { | |||
log.info("Initialized AnnotationHandlerMapping!"); | |||
collectAllControllerClasses().forEach(this::generateHandlerExecutions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메서드 분리 깔끔하게 잘 해주셨네요👍
안녕하세요 리뷰어 마코!
어떻게 건드려야할지 감이 잘 안와서
테스트가 통과할 정도로만 AnnotationHandlerMapping과 HandlerExecution를 수정해보았습니다
리뷰 잘 부탁드립니다 ~~