[MVC 구현하기 - 1단계] 레오(차영호) 미션 제출합니다. #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanueleee
approved these changes
Sep 14, 2023
| GET, HEAD, POST, PUT, PATCH, DELETE, OPTIONS, TRACE | ||
| GET, HEAD, POST, PUT, PATCH, DELETE, OPTIONS, TRACE; | ||
|
|
||
| public static RequestMethod from(String methodName) { |
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class RequestMethodTest { |
| void 존재하지_않는_메서드면_예외() { | ||
| String invalidMethodName = "get??"; | ||
|
|
||
| Assertions.assertThatThrownBy(() -> RequestMethod.from(invalidMethodName)) |
Comment on lines
13
to
21
| private final Constructor<?> constructor; | ||
|
|
||
| public HandlerExecution(Method method, Constructor<?> constructor) { | ||
| this.method = method; | ||
| this.constructor = constructor; | ||
| } | ||
|
|
||
| public ModelAndView handle(final HttpServletRequest request, final HttpServletResponse response) throws Exception { | ||
| return null; | ||
| return (ModelAndView) method.invoke(constructor.newInstance(), request, response); |
There was a problem hiding this comment.
constructor를 상태로 갖고 있고
handle 메소드 호출시마다 constructor로 새로 instance를 만드는 이유가 궁금합니다!
Comment on lines
+49
to
+56
| private Constructor<?> getConstructor(Class<?> controller) { | ||
| try { | ||
| return controller.getConstructor(); | ||
| } catch (NoSuchMethodException e) { | ||
| log.error("{} 의 기본 생성자가 존재하지 않습니다.", controller.getName()); | ||
| throw new RuntimeException(String.format("%s 의 기본 생성자가 존재하지 않습니다.", controller.getName())); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 오잉! 레오입니다
미션에서 만나니 반갑네요😎
1단계 로직 흐름에 대해 간단하게 말씀 드리자면 아래와 같습니다.
리뷰 하시다가 궁금한 점 있으면 언제든 물어봐주십쇼~ MVC 미션 잘 부탁드려요 ㅎㅎ