[@MVC 구현하기 - 1단계] 필립(양재필) 미션 제출합니다. #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonyj1022
approved these changes
Sep 14, 2023
Comment on lines
+75
to
+76
| private HandlerKey getHandlerKey(final HttpServletRequest request) { | ||
| return new HandlerKey(request.getRequestURI(), RequestMethod.valueOf(request.getMethod())); |
There was a problem hiding this comment.
valueOf는 파라미터의 문자열이 대문자일 때만 원하는 결과를 얻을 수 있습니다. 만약 클라이언트측에서(사실 그럴 일이 없을 것 같기는 하지만,,) request method를 소문자로 보내면 어떻게 될까요?
Comment on lines
+37
to
+53
| for (final Class<?> controllerClass : controllerClasses) { | ||
| try { | ||
| final Object controller = controllerClass.getDeclaredConstructor().newInstance(); | ||
| final Set<Method> handlerMethods = getHandlerMethods(controllerClass); | ||
|
|
||
| for (final Method method : handlerMethods) { | ||
| putHandler(controller, method); | ||
| } | ||
| } catch (InstantiationException | | ||
| IllegalAccessException | | ||
| InvocationTargetException | | ||
| NoSuchMethodException e | ||
| ) { | ||
| log.error("Fail Initializing Controller - " + e.getMessage(), e); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
전체적으로 메서드 분리를 잘해주셨군요👍
이 부분 depth가 조금 큰 것 같은데, 우테코 컨벤션에 맞게 리팩터링 할 수 있다면 더더 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 엔초!!
이번 미션 잘 부탁드려요~~ 😄
리플렉션 공부하고, 사용해보는게 처음이라,, 어색하거나 이상하게 한 부분이나, 그 외에 코드적인 부분들도 편하게 지적 부탁드립니다!!
앞의 커밋들은 학습테스트 커밋들이고,, 1단계 요구사항인
AnnotationHandlerMapping구현 부분은 커밋 확인해주시면 됩니다!그냥 맵핑부분만 있어서 커밋이 하나네요..ㅎㅎ
잘부탁드립니다!!