[MVC 구현 - 3단계] 로지(윤가영) 미션 제출합니다. #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This2sho
requested changes
Sep 25, 2023
There was a problem hiding this comment.
급하게 구현하셨다고 하셨지만... 잘하셨네요 로지 👍
#466 (comment) 이 부분은 저도 사실 왜 안되는지 이해가 안되서 계속 해봤는데.. 아직도 왜 그런지 모르겠네요..
같이 해결해보시죠..🥹
(너무 바로 approve만 한거 같아서.. 한번만 request change로.....🥲)
|
|
||
| /** | ||
| * Base class for {@link WebApplicationInitializer} implementations that register a {@link DispatcherServlet} in the | ||
| * servlet context. | ||
| */ | ||
| public class DispatcherServletInitializer implements WebApplicationInitializer { | ||
| public class AppInitializer implements WebApplicationInitializer { |
There was a problem hiding this comment.
오홍 DispatcherServletInitializer 에서 AppInitializer 으로 이름을 바꾼 이유가 있을까유?!
There was a problem hiding this comment.
아, 별의미는 없었습니다. 이건 저의 아쉬움이 반영된 변경사항이었어요.
DispatcherServlet이 아니라 App으로 변경하면 app 모듈에 조금 더 직관적이지 않을까? 생각했어요.
애초에 저 이름이 있었어서 계속 mvc 모듈로 옮기려고 집착한 것 같다는 이유도 있습니다.. 하하.
mvc/src/main/java/webmvc/org/springframework/web/servlet/mvc/DispatcherServlet.java
Show resolved
Hide resolved
|
|
||
| public class DispatcherServlet extends HttpServlet { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
| private static final Logger log = LoggerFactory.getLogger(DispatcherServlet.class); | ||
|
|
||
| private List<HandlerMapping> handlerMappings; | ||
| private final List<HandlerMapping> handlerMappings; |
There was a problem hiding this comment.
오오, 잊고있었던 일급컬렉션... 적용해보겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
급하게 3단계를 구현했습니당..
사실 3단계는 그닥 고민을 하지 못했어요.
2단계에서 시도했던 mvc 모듈로 DispatcherServlet을 분리하는 과정에서의 의문이 아직 해결이 되지 않았기 때문인데요..
#466 (comment)
제 학습이 부족한 탓인지.. 단시간에 정복하기엔 어려운 내용인건지.. 아직 이해를 하지 못했어요.
호이와 이야기하면서 해결해보고싶은데 괜찮을까요?🥹