Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

커리큘럼 별 퀴즈 API 생성 #1610

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

BGuga
Copy link
Contributor

@BGuga BGuga commented Oct 25, 2023

#️⃣연관된 이슈

📝작업 내용

커리큘럼 별 퀴즈 검색 기능을 구현했습니다.
중첩 Join 문을 사용했는데, 흐름이 curriculum -> session -> keyword -> quiz 순으로 진행하려 했고
그 이유는 드라이빙 테이블의 컬럼을 줄이기 위해서입니다.
Join 과정에서 session 이 curriculum에 대한 인덱스가 없어 풀테이블 스캔을 하는데 session 의 경우 사용하지 않을 데이터면서 데이터가 그렇게 많이 생길 것 같지도 않기에 인덱스는 생략했습니다

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Comment on lines +69 to +70
@GetMapping("/curriculums/{curriculumId}/quizzes")
public ResponseEntity<List<CurriculumQuizResponse>> findQuizzesByCurriculum(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 매핑을 어떻게하면 좋을까요?

@BGuga BGuga merged commit 9a44012 into develop Nov 2, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant