-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
로그인 Interceptor 개선 #1616
로그인 Interceptor 개선 #1616
Conversation
SonarCloud Quality Gate failed. 0 Bugs 67.6% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 푸우!
아까 설명해주신 덕분에 코드 이해가 한 결 쉬웠습니다ㅎㅎ
어려운 작업이었을텐데 수고 많으셨어요.
전체적으로 크게 수정할만한 부분은 보이지 않는 것 같습니다. 테스트코드도 꼼꼼하게 작성해주셨구요.
그러니 approve하도록 하겠습니다!
@@ -46,7 +46,7 @@ public class KeywordRecommendedPostStepDefinitions extends AcceptanceSteps { | |||
public void 추천_포스트가_수정된다() { | |||
int statusCode = context.response.statusCode(); | |||
|
|||
assertThat(statusCode).isEqualTo(HttpStatus.OK.value()); | |||
assertThat(statusCode).isEqualTo(HttpStatus.NO_CONTENT.value()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 상태코드도 적절하게 수정해주셨네요! 굿입니다^^*
#️⃣연관된 이슈
#1612
📝작업 내용
위와 같은 상황에서 Delete method에서도 로그인 검증이 일어나는 문제가 있었습니다.
이를 MethodPattern 이란 객체를 생성하여 메서드와 uri 두 가지가 만족해야 검증하도록 변경했습니다.